logger icon indicating copy to clipboard operation
logger copied to clipboard

Published 20 hours ago • verified publisher icon kazu-yamamoto

Export newFDLoggerSet

Open ocharles opened this issue 9 years ago • 5 comments

Is there any reason to have this private?

ocharles avatar Jan 19 '16 09:01 ocharles

It depends on FD. I don't know that it is a good thing to export FD or not.

kazu-yamamoto avatar Jan 19 '16 12:01 kazu-yamamoto

In fact, I'd say just export LoggerSet. Right now I just wanted to create my own, but I'm completely stuck.

ocharles avatar Jan 20 '16 09:01 ocharles

I'm OK to create the Internal module and export something in it. Is LoggerSet(..) enough for you?

kazu-yamamoto avatar Jan 20 '16 12:01 kazu-yamamoto

Sounds good, it might be worth putting LogStr in there too. I don't think there is really much benefit preventing people constructing these by hand if they so desire too (but keeping the constructors out of the main documentation sounds good).

ocharles avatar Jan 20 '16 13:01 ocharles

If you want to create System.Log.FastLogger.Internal by yourself, please do it and send me a pull request. If not, it will do it.

kazu-yamamoto avatar Jan 20 '16 13:01 kazu-yamamoto