Steve Bilogan

Results 134 comments of Steve Bilogan

There's a tradeoff here that we have to figure out, either you have fontfamily specific resource keys for each control or they use the ones coming directly from Typography.xaml. If...

FYI @NVLudwig, may be something interesting to add to the material figma file eventually?

@Mergifyio backport release/stable/5.0

@iurycarlos I believe the Pane background needs to be set by overriding certain lightweight styling resources. https://learn.microsoft.com/en-us/windows/apps/design/controls/navigationview#pane-backgrounds cc @carldebilly / @agneszitte NavigationView - Windows appsNavigationView is an adaptive control that...

Yeah I'd say the delete button should be available on its own since it is built into the TextBox control itself. We wouldn't need to use the attached properties and...

Okay, @agneszitte / @Xiaoy312, let's decide on an official spec for this ### Leading Icon / Command Update `ControlExtensions.Icon` to `ControlExtensions.LeadingIcon` and add a `ControlExtensions.LeadingIconCommand` For trailing icons, I believe...

i don't want to touch the clear button at all, that's its own thing that is owned by TextBox. Let's just add the Command for the leading icon and a...

So for now we will have: ### Leading Icon / Command Update `ControlExtensions.Icon` to `ControlExtensions.LeadingIcon` and add a `ControlExtensions.LeadingIconCommand` and `ControlExtensions.IsLeadingIconVisible` ### Trailing Icon / Command Create `ControlExtensions.TrailingIcon` and `ControlExtensions.TrailingIconCommand`...

@Xiaoy312 I feel like there was some sort of reason that this wasn't done, the clipping of the outline by the label maybe?