dynamodb-data-types icon indicating copy to clipboard operation
dynamodb-data-types copied to clipboard

Implement unwrap for lower-case type strings

Open arichiardi opened this issue 7 years ago • 4 comments

Avoid failing with a "No data type (B, BS, N, NS, S, SS)" error when type strings are not upper case.

arichiardi avatar Mar 23 '17 18:03 arichiardi

Coverage Status

Coverage increased (+0.02%) to 96.532% when pulling 72033b096d2b041c8aba9b03fa2a486703497675 on arichiardi:lowercase-support into 5bb4c7a54e409f3e4d0c9062084616c3ed4832c5 on kayomarz:master.

coveralls avatar Mar 23 '17 18:03 coveralls

Well, I have had DynamoDB extract data in lowercase while using Data Pipeline that is why I needed it.

In any case up to you 😀

arichiardi avatar Mar 27 '17 14:03 arichiardi

Ok. I understand.

I will merge your pull request, maybe with a global flag to allow lowercase data types. Maybe something like:

var ddt = require('dynamodb-data-types'); ddt.allowLowercaseDataType();

Let me know if you have any other suggestion. Thanks!

On 27-Mar-2017 10:42 am, "Andrea Richiardi" [email protected] wrote:

Well, I have had DynamoDB extract data in lowercase while using Data Pipeline that is why I needed it.

In any case up to you 😀

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/kayomarz/dynamodb-data-types/pull/10#issuecomment-289474808, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIkCXoXr-8iMM3exO76FgKqJfjlDtYDks5rp8rLgaJpZM4MnKPQ .

kayomarz avatar Mar 27 '17 17:03 kayomarz

In my experience of importing/exporting text files into/from DynamoDB using Data Pipeline, only the first letter of the data type is set to lower case.

Additionally, it places a char(3) rather than a colon between root level field names & their data and then a char(2) between fields.

YMMV

prothschell-lowtcenter avatar Mar 27 '18 06:03 prothschell-lowtcenter