Kayce Basques
Kayce Basques
OK the PR is up! #2093
Upstream Sphinx discussion is here: https://github.com/orgs/sphinx-doc/discussions/13222 (I previously said that I would kick off a discussion in upstream Sphinx making them aware of this extended usage of `searchtools.js`)
I will send a PR proposing some docs updates next week and then we can close this issue out
I don't think I'll get around to the docs update (and I don't think it's that important) so I will just close this out in the spirit of not cluttering...
Hi @chrisjsewell picking this back up. I addressed your first round of comments. LMK if you want to proceed with this and I will add the same a11y fix/feature to...
OK, I've got this working with all built-in themes. See the attached screencast for verification. [verify.webm](https://github.com/user-attachments/assets/38bfbb69-eb31-4f80-9170-9de5363b12ba)
@trallard thanks for the review, I updated the feature to jump directly to the main content container and made sure that the "skip to main content" node does not leak...
hi @chrisjsewell this should be good to go now
accidentally closed the pr by deleting my local branch, re-opening
This occurs within normal reST text, is that right? E.g. a normal paragraph containing the text `C++` might put the break between the two `+` characters.