pypika
pypika copied to clipboard
kayak
Arithmetic Order of Operations Bug
Hi All,
When using parens in statements I would expect them to be carried forward into the generated sql to ensure that my intended order of operations was maintained.
I'd expect that
from pypika.terms import Term
example = Term.wrap_constant(1.0) / Term.wrap_constant(2.0) * Term.wrap_constant(3.0)
example_with_parens = Term.wrap_constant(1.0) / (Term.wrap_constant(2.0) * Term.wrap_constant(3.0))
would generate different sql representations 1.0/2.0*3.0 and 1.0/(2.0*3.0) respectively. However, that does not appear to be the case.
It seems that parentheses are being ignored when constructing sql for division and multiplication. I see this is done so explicitly in ArithmeticExpression. I think this causes a correctness issue when parens are used, as the above examples produce identical sql.
print((example.get_sql(),
example_with_parns.get_sql(),
example.get_sql() == example_with_parns.get_sql()))
> ('1.0/2.0*3.0', '1.0/2.0*3.0', True)
This results in both example and example_with_parens returning 1.50 when executed, but the example_with_parens should return 0.166.
