boring-cyborg icon indicating copy to clipboard operation
boring-cyborg copied to clipboard

Published 20 hours ago • verified publisher icon kaxil

Protecting from too big pull request (invalid source branch, master meged fork)

Open ad-m opened this issue 4 years ago • 1 comments

Hello,

In projects, it happens that someone pull request points to the wrong source branch eg. https://github.com/apache/airflow/pull/8968 . In this case, the proposed changes are huge. Often, the source branch is also not a branch from which pull requests can be expected.

While waiting for the changes to be merged, it happens that the developers merge the master to feature branch to be able to use feature branch directly (installation directly from Git). These pull requests cannot be implemented also.

What can we do about it to support a community that makes pull requests invalid?

Greetings,

ad-m avatar May 23 '20 11:05 ad-m

We have 2 options:

  1. Create a flag to allow adding branch names for which a project accepts a PR: If someone creates a PR to another target branch, the bot can comment and close the PR

  2. Delete any branches for example in this particular case, the branch was created by dependable which we don't plan to use in Airflow project.

WDYT?

kaxil avatar May 25 '20 20:05 kaxil