msgpack-lite icon indicating copy to clipboard operation
msgpack-lite copied to clipboard

Full uint32 and partial int64/uint64 support

Open marcinkowskip opened this issue 7 years ago • 1 comments

Hello,

Great library @kawanet. I have noticed that uint32 support is limited (up to 2147483647) and int64/uint64 is not supported at all. I have prepared a patch which removes uint32 limit and adds int64/uint64 support (up to 2^53). Unfortunately, it can slow down the performance because float detection is replaced with Math.floor() function. Can you at least verify if the approach is proper?

Thanks, PM uint32-int64-uint64-support-added.txt

marcinkowskip avatar Mar 09 '18 10:03 marcinkowskip

+1 for this (or similar) change. I discovered that hard way that I have to manually examine a js number and either send it to msgpack as a Uint64 or Int64 object from another library! This is the only way I can get cross-platform compatibility as other implementations treat negative numbers > 32 bits as uint64 whereas msgpack-lite treats it as an int64.

mattbishop avatar Oct 02 '18 14:10 mattbishop