msgpack-lite icon indicating copy to clipboard operation
msgpack-lite copied to clipboard

Benchmarks innacurate

Open endel opened this issue 9 years ago • 3 comments

Hey @kawanet,

That's not really an issue.

I just want to share that I've been doing some benchmarks recently, and it seems that msgpack-javascript and msgpack-js-v5 performs better in some cases.

Maybe it would be nice to have different inputs for the benchmarks in your README, since some projects may have different needs when choosing a library like this.

Congrats for your implementation, which seems really great! Cheers

endel avatar Nov 20 '15 20:11 endel

@endel - Your benchmarks aren't doing what you think they are. You forgot to JSON.parse the data. Once you change this, msgpack-lite should perform a lot better relatively.

mtth avatar Nov 29 '15 01:11 mtth

@mtth oops, you're right! I've made this change and updated the README with new results. Thanks for checking out.

I've also added the same sample used to benchmark msgpack-lite here: sample-datatypes.json - and msgpack-lite indeed stands out in this case.

endel avatar Nov 29 '15 17:11 endel

This can probably be closed :)

dbrgn avatar May 31 '16 13:05 dbrgn