zfs-scripts icon indicating copy to clipboard operation
zfs-scripts copied to clipboard

Code contribution?

Open srlefevre opened this issue 11 years ago • 3 comments

I have a code contribution if your interested. Here's what I've done with your code so far: -support for other *nix platforms (CentOS, OpenIndiana) -support for longer retention level on target server (added -x option) -support for config file (/etc/zfs-replicate.conf) -support for non-root user on target system (can use -h user@target instead of -h root@target but user must be setup for sudo) -fixed a few typos -added log option

Let me know how I can get it to you. -Scott

srlefevre avatar Apr 03 '13 12:04 srlefevre

Hi, I have this abandoned for a while, but yes, I'm interested. Do you want to sent to me by mail, or do you want to add you as a collaborator to the project?

kattunga avatar Jul 29 '13 16:07 kattunga

I think I'd like to add as a collaborator. That would allow me to push any improvements up without bothering you.

I've made several changes that allow the script to be more flexible and run more platforms. Here's a list of the changes I've made (from the script)

Enhancements:

2013.04.16

By slefevre

- added support for mbuffer protocol

2013.04.09

By slefevre

-made snapshot cleanup functions restrictive to prefix (-f option)

value. No prefix == all snapshots

2013.04.05

By: slefevre

-added syslog capability

2013.04.03

By: slefevre

-added -q option for crontab scheduling w/out emails

2013.04.02

By: slefevre

-support for other *nix platforms (CentOS, OpenIndiana)

-support for longer retention level on target server (added -x option)

-support for config file (/etc/zfs-replicate.conf)

-support for non-root user on target system (can use -h user@target

instead of -h target but user must be setup for sudo)

-fixed a few typos

-added log option

-better isolation of flag/lock & err files better concurrenct

replication of different source paths

Scott LeFevre 317-696-1010

On Mon, 2013-07-29 at 09:29 -0700, kattunga wrote:

Hi, I have this abandoned for a while, but yes, I'm interested. Do you want to sent to me by mail, or do you want to add you as a collaborator to the project?

— Reply to this email directly or view it on GitHub.

srlefevre avatar Jul 31 '13 12:07 srlefevre

Hi, I added you as a collaborator. I'll be uploading some minor changes today and then I'll branch current version so you can upload your contributions to master branch.

kattunga avatar Jul 31 '13 15:07 kattunga