wavesurfer-react icon indicating copy to clipboard operation
wavesurfer-react copied to clipboard

creates a hasFinished state

Open robotastic opened this issue 1 year ago • 1 comments

It doesn't look like it is possible to get the 'finish' event when you are using WaveSurfer as a hook. This PR creates a State for whether the 'finish' event has fired. It is reset when 'ready' event is fired. This makes it possible to have useEffect related to this event.

There maybe a better way of doing this... but this seems to work

Summary by CodeRabbit

  • New Features
    • Introduced a new playback state indicator, hasFinished, to track audio playback completion.
    • Updated the app to reflect the new playback state in the user interface.

robotastic avatar Sep 28 '24 14:09 robotastic

Walkthrough

The changes introduce a new state variable, hasFinished, to the useWavesurferState hook, which tracks the completion of audio playback. The initial state is set to false, and it updates to true upon the finish event from the wavesurfer instance. The state resets to false during the ready event. The return object of the hook now includes hasFinished, which is also destructured in the App component where useWavesurfer is utilized.

Changes

Files Change Summary
src/index.tsx Added hasFinished state variable to useWavesurferState hook; updated return type and usage in App component.

Poem

In the land of sound, where waves do play,
A rabbit hops, brightening the day.
With hasFinished now, we know when to cheer,
For every note played, brings music near!
So let’s dance and sing, with joy in our hearts,
For every new change, a fresh tune starts! 🐇🎶


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 28 '24 14:09 coderabbitai[bot]