There was a off-by-one in buffer for the onion address.

[Freaken]

The base32_onion function writes BASE32_ONIONLEN+1 bytes to the buffer, however the onion buffer only contains BASE32_ONIONLEN bytes.

[nikcub]

this needs to be merged, get lots of false positives without this patch

[herzi]

This bug happens to me as well.

I can verify that base32_onion() indeed needs a buffer with the size of BASE32_ONIONLEN + 1 (see src/print.c: The method will write to but[BASE32_ONIONLEN] in the end).

If you add me to the github collaborators for this repo, I'd love to take a look at this and other pull requests and merge them into this repository.