lmtp-tutorial icon indicating copy to clipboard operation
lmtp-tutorial copied to clipboard

Update `lmtp_sdr()` call to v1.4.0 ?

Open swihart opened this issue 5 months ago • 0 comments

Thanks for the repo and the Epidemiology paper! Should the following chunk in run_lmtp.R be updated with lmtp_control()?

That is, update

progressr::with_progress(
  out_null <-
    lmtp_sdr(
      dat,
      trt = a[seq_len(this_time)],
      outcome = y[seq_len(this_time)],
      baseline = bs,
      time_vary = tv[seq_len(this_time)],
      cens = censoring[seq_len(this_time)],
      outcome_type = ifelse(this_time == 1, "binomial", "survival"),
      #learners_outcome = lrnrs,
      #learners_trt = lrnrs,
      folds = folds,
      .SL_folds = SL_folds,
      .trim = trim,
      k = k
      )
)

to

progressr::with_progress(
  out_null <-
    lmtp_sdr(
      dat,
      trt = a[seq_len(this_time)],
      outcome = y[seq_len(this_time)],
      baseline = bs,
      time_vary = tv[seq_len(this_time)],
      cens = censoring[seq_len(this_time)],
      outcome_type = ifelse(this_time == 1, "binomial", "survival"),
      #learners_outcome = lrnrs,
      #learners_trt = lrnrs,
      folds = folds,
      #.SL_folds = SL_folds,
      #.trim = trim,
      control=lmtp_control(.trim=trim, .learners_trt_folds=SL_folds, .learners_outcome_folds = SL_folds),
      k = k
      )
)

swihart avatar Sep 19 '24 20:09 swihart