Paul Meyer comments

Results 76 comments of


                                            Paul Meyer

Can't do hash update on Go module in a flake

IMO this is a bug. It should work for packages that don't have a version specified when `--version=skip` is passed.

New formatter: Add golangci-lint support

> `treefmt` seems to make the assumption that running its formatters in parallel is safe, which `golangci-lint` doesn't like. golangci-lint doesn't comply with the treefmt spec: https://treefmt.com/formatters-spec/

`--accept` doesn't accept the same values as `--cache-exclude-status`

> ..100 This actually seem to work as intended.

--cache-exclude-status can't exclude failures that have no status code

> Alternatively, errors without a status code should never be cacheable. Agree, that's a good solution.

themes: load/save by name if possible

Thanks for the review @eclairevoyant, I think I fixed the issue, could you check again?

themes: load/save by name if possible

> First issue is fixed, sort order is still off. Prior to this PR, theme 3 onward is sorted lexically. So `HotPurpleTrafficLight`, `adapta`, `adwaita-dark`, ... after this PR, the sort...