func_timeout icon indicating copy to clipboard operation
func_timeout copied to clipboard

Drop python2 support, add py38 and py39

Open ikamensh opened this issue 4 years ago • 5 comments

Hi, I'd like to use this library on py38 and higher. Since py2 and py35 are outdated, I have removed them and applied some automatic refactorings for newer python. All refactorings were done with tools (pyupgrade, flynt) so should be low risk. Test testit.py passes.

ikamensh avatar Jan 17 '21 12:01 ikamensh

It would be good to merge that change and make new release.

kloczek avatar May 16 '21 15:05 kloczek

pretty please.. pull this and push a release to pypi

ddurham2 avatar Dec 29 '21 05:12 ddurham2

Sorry for late reply, I am retired. Can we do this in a way that does not lose python2 support? I am not willing to lose that. Perhaps the .format function? That should work for both 2 and 38.

kata198 avatar Jan 30 '22 23:01 kata198

If you're using your own pip package, could you not just lock to a specific version in your application's requirements.txt/setup.py (e.g. func_timeout==4.3.5)?

ddurham2 avatar Jan 31 '22 00:01 ddurham2

Yeah you could. If you are using artifactory or whatever the new deal is, you can just publish a version 4.3.6 with your own changes, and it would always fetch that.

I'm not sure if you are asking me to do something, but some very important systems I developed use this lib, and I no longer work at the agencies that do in order to update their requirements.txt file. I imagine a lot of other code I didn't even write is in the same predicament. If you just change all the f"blah %{variable}" to use str.format instead, I can publish that and not break anyone whilst supporting new deployments. I no longer own a computer to make.these changes myself.

kata198 avatar Jan 31 '22 00:01 kata198