tests icon indicating copy to clipboard operation
tests copied to clipboard

Ignore/Skip `checkcommits` in static-check.sh

Open bergwolf opened this issue 3 years ago • 3 comments

Which feature do you think can be improved?

We have both commit-message-check.yaml in GH action and checkcommits in static-check.sh to validate commit messages.

How can it be improved?

There is no need to validate twice. We can just rely on the GH action to do it, and let static_check.sh focus on static code inspection.

bergwolf avatar Jan 24 '22 03:01 bergwolf

/cc @jodh-intel @Tim-Zhang

bergwolf avatar Jan 24 '22 03:01 bergwolf

@bergwolf DYT #4409 already covers this?

Jakob-Naucke avatar Jan 28 '22 16:01 Jakob-Naucke

With checkcommits removed #4878, this should be able to be closed.

bookinabox avatar Jul 12 '22 21:07 bookinabox