tests icon indicating copy to clipboard operation
tests copied to clipboard

k8s: run CPU test on firecracker

Open egernst opened this issue 3 years ago • 8 comments

With static sandbox resource management, this test should pass.

Fixes: #xxxx Depends-on: github.com/kata-containers/kata-containers#2941 Signed-off-by: Eric Ernst [email protected]

egernst avatar Jan 18 '22 17:01 egernst

/test

egernst avatar Jan 18 '22 17:01 egernst

The Firecracker job is the only "interesting one" here -- I'll want to see it pass, then perhaps drop the "depends on" to verify it fails without the runtime fix. 🤞🏻

egernst avatar Jan 18 '22 17:01 egernst

/test

egernst avatar Jan 18 '22 18:01 egernst

/test

egernst avatar Jan 18 '22 18:01 egernst

Actually, this will require migrating to K8S 1.23 and container 1.6 -- will put this into draft for now

egernst avatar Jan 19 '22 05:01 egernst

A head's up that may affect your PR.

In the Architecture Committee meeting from January 25th, 2022, the Architecture Committee has agreed on using the "Dismiss stale pull request approvals when new commits are pushed" configuration from GitHub. It basically means that if your PR has been rebased or updated, the approvals given will be erased.

In order to minimize traumas due to the new approach, please, consider adding a note on the changes done before the rebase / force-push, and also pinging the reviewers for a subsequent round of reviews.

Thanks for your understanding!

Related issue: https://github.com/kata-containers/community/issues/249

fidencio avatar Jan 26 '22 12:01 fidencio

@egernst - Can this PR leave "draft mode" yet?

jodh-intel avatar Mar 25 '22 08:03 jodh-intel

Ping @egernst et al - we need another review and to decide if this can leave draft mode.

jodh-intel avatar Apr 26 '22 14:04 jodh-intel

As we're in the process (a still long process) of moving tests from this repo to the kata-containers one, we're closing PRs that are either stale for too long.

Please, if you think this has been mistakenly closed, open it agains the kata-containers repo as in the coming months this repo will be archived.

fidencio avatar Jul 14 '23 14:07 fidencio