kata-containers icon indicating copy to clipboard operation
kata-containers copied to clipboard

CI: Fix "make kata-manager-tarball" after "make rootfs-image-tarball"

Open koct9i opened this issue 7 months ago • 0 comments

"make kata-manager-tarball" called by non-root fails when stumbles upon prebuild rootfs:

  • install_kata_manager
  • install_script_helper kata-manager.sh
  • local script=kata-manager.sh
  • '[' -n kata-manager.sh ']'
  • local script_path
  • grep -q / ++ find <SRC> -type f -name kata-manager.sh find: '<SRC>/tools/packaging/kata-deploy/local-build/build/rootfs-image/builddir/rootfs-image/ubuntu_rootfs/root': Permission denied
  • script_path=<SRC>/utils/kata-manager.sh make[1]: *** [tools/packaging/kata-deploy/local-build/Makefile:72: kata-manager-tarball-build] Error 1 make[1]: Leaving directory '<SRC>' make: *** [tools/packaging/kata-deploy/local-build/Makefile:102: kata-manager-tarball] Error 2

Recursive lookup source file with certain name within own sources is a strange and fragile approach. Let's use full path here. Helper "install_script_helper" is used only once.

Signed-off-by: Konstantin Khlebnikov [email protected]

koct9i avatar Jul 09 '24 09:07 koct9i