kata-containers icon indicating copy to clipboard operation
kata-containers copied to clipboard

kata-deploy: improving the runtimeclasses checker and documentation

Open wainersm opened this issue 1 year ago • 4 comments

While working on PR #9807 it was a little of a pain to pass the static checker for the runtimeClasses that kata-deploy deploys on the cluster. I realized that it wasn't the first time I had the same difficult to pass CI, likely because I wasn't able to run the checker locally. So here I am sending some improvements to allow devs to run the checker locally before submitting a PR. In particular, the LC_ALL=C trick was hurting my tentative to get the checker passing.

Taking that opportunity to also document how to add a new runtimeClass to kata-deploy.

wainersm avatar Jun 11 '24 18:06 wainersm

Tentatively making spell and commit checkers happy.

wainersm avatar Jun 11 '24 20:06 wainersm

Updated to address @beraldoleal 's suggestion; now the job's name is on first line.

wainersm avatar Jun 13 '24 18:06 wainersm

Updated this PR to address @ldoktor 's comments.

wainersm avatar Jun 25 '24 18:06 wainersm

Updated this:

  • rebased to main
  • using select instead of indexes to get the shim list

wainersm avatar Jun 26 '24 13:06 wainersm

This PR has been opened without with no activity for 180 days. Comment on the issue otherwise it will be closed in 7 days

github-actions[bot] avatar Apr 20 '25 00:04 github-actions[bot]