python-tail icon indicating copy to clipboard operation
python-tail copied to clipboard

Published 20 hours ago • verified publisher icon kasun

support for binary files

Open rgalonso opened this issue 6 years ago • 1 comments

Added an optional argument to constructor to specify the mode argument to the file open command. Defaults to 'r', for backwards-compatibility. The specific use case this addresses is supporting binary-encoded encoded files by specifying the mode as 'rb'. While using this module to parse pcap files generated by Wireshark, I found this to be a necessary change.

rgalonso avatar Apr 05 '18 16:04 rgalonso

@kasun, I'd completely forgotten about this PR, but just noticed it's still open and has no merge conflicts. Please let me know if there's something that needs to be changed to accept this PR.

rgalonso avatar Apr 17 '23 13:04 rgalonso