kasperk81
kasperk81
reverted, here is the history: https://github.com/SixLabors/ImageSharp/commits/522843cf11e6f965a3ad8f82304a573dd44222ff/. it fixes all CA warnings, passes all CI jobs with .net8, but fails all CI jobs with .net9 due to ONE test failure: ```...
@JimBobSquarePants i didn't get a chance to isolate a repro to report something actionable upstream. it's off by 0.0018% can we adjust the tolerance for VerifySimilarity? i haven't checked how...
> System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified. File name: 'Microsoft.VisualStudio.SolutionPersistence, Version=1.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' is it about adding ``...
i just searched how the other dependencies are set up https://github.com/search?q=repo%3Adotnet%2Fmsbuild%20System.Configuration.ConfigurationManager&type=code maybe feature switch pulled something which made the fragile dependency graph in torn state, which means it needs to...
entry maybe needed here as well https://github.com/dotnet/msbuild/blob/b8f46eb171f3b1c7e3bddb8afaff9fbb0ba59e9d/eng/Packages.props#L21
ah dependabot one is included in eng/Packages.props. the other two diffs are: https://github.com/dotnet/msbuild/blob/b8f46eb171f3b1c7e3bddb8afaff9fbb0ba59e9d/src/MSBuild/MSBuild.csproj#L178 https://github.com/dotnet/msbuild/blob/b8f46eb171f3b1c7e3bddb8afaff9fbb0ba59e9d/src/Utilities/Microsoft.Build.Utilities.csproj#L27 (missing persistence package ref)
@YuliiaKovalova do you know how to add new dependency in bootstrap? i read https://github.com/dotnet/msbuild/blob/5881e053656bc8aaa890515e5d4318af39f49dc5/documentation/wiki/Bootstrap.md and tried adding Microsoft.VisualStudio.SolutionPersistence around here https://github.com/dotnet/msbuild/blob/5881e053656bc8aaa890515e5d4318af39f49dc5/eng/BootStrapMsBuild.targets#L37 but the error doesn't go away. it's about copying...
lets see what happens if we now merge main (fingers crossed) :)
the one failing test `Microsoft.Build.BuildCheck.UnitTests.TaskInvocationCheckDataTests.ReportsComplexTaskParameters` seems unrelated (it also failed in https://github.com/dotnet/msbuild/pull/10813)
@bording pending https://github.com/libgit2/libgit2sharp.nativebinaries/issues/167. we need riscv64 there. e.g. ubuntu 24.04 riscv64 is the first version with official riscv64 support