Kasper Isager Dalsgarð

Results 81 comments of Kasper Isager Dalsgarð

I just hit this as well moving from Autotools to CMake for compatibility reasons. Is there a desire to align the two toolchains? If so, I'd be happy to submit...

Does the opinion expressed in https://github.com/libuv/libuv/pull/2374#issuecomment-522240794 still stand? That was one of the differences I encountered.

I don't have an overview of how the CMake build is used, though I know the Autotools build is very much depended on to produce `libuv.{a,dylib,so}` artefacts. That does seem...

I'm currently working on TypeScript typings for Unexpected with a goal to cover as much of the API as possible. Since I need the typings for plugin development I expect...

That can absolutely be done, though the core typings (`expect()`, `use()`, `clone()`, `addAssertion()`, etc.) would still have to be maintained somewhere rather than generated. Currently, `expect()` is only minimally typed:...

The typings I have so far can be found here: https://github.com/Siteimprove/alfa/blob/master/packages/alfa-unexpected/types/unexpected.d.ts

I've pulled in your typings to see if our packages still type, and it looks like the only thing missing is either a general overload for the `expect()` function (similar...

The general overload would actually be required regardless as there would otherwise be no way to invoke custom assertions. One of the issues I ran in to when implementing the...

Your approach made me realise how it can be done with just a type declaration 👌 Voilá: https://github.com/Siteimprove/alfa/commit/f0fa281f3993706bbf67daedb147632594f09313

> IMHO, I don't think typing up all the different assertions is a terribly good idea. We add quite a few assertions of our own, and AFAIK, we wouldn't be...