kaspad icon indicating copy to clipboard operation
kaspad copied to clipboard

Set kaspawallet daemon send/recv message size limits to 100MB

Open michaelsutton opened this issue 2 years ago • 2 comments

michaelsutton avatar Jul 16 '22 21:07 michaelsutton

Codecov Report

Merging #2117 (351a9a7) into dev (b26b9f6) will decrease coverage by 0.00%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #2117      +/-   ##
==========================================
- Coverage   59.16%   59.16%   -0.01%     
==========================================
  Files         678      678              
  Lines       32897    32905       +8     
==========================================
+ Hits        19464    19467       +3     
- Misses      10618    10621       +3     
- Partials     2815     2817       +2     
Impacted Files Coverage Δ
cmd/kaspawallet/common.go 0.00% <ø> (ø)
cmd/kaspawallet/daemon/client/client.go 0.00% <0.00%> (ø)
cmd/kaspawallet/daemon/server/server.go 0.00% <0.00%> (ø)
...ructure/network/rpcclient/grpcclient/grpcclient.go 76.56% <0.00%> (-4.69%) :arrow_down:
app/rpc/rpccontext/notificationmanager.go 59.44% <0.00%> (-1.39%) :arrow_down:
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 52.63% <0.00%> (-0.81%) :arrow_down:
...selectedchainstore/headers_selected_chain_store.go 75.58% <0.00%> (+6.97%) :arrow_up:
...ain/consensus/database/binaryserialization/hash.go 78.26% <0.00%> (+8.69%) :arrow_up:
...tructure/network/rpcclient/rpc_on_chain_changed.go 66.66% <0.00%> (+14.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b26b9f6...351a9a7. Read the comment docs.

codecov[bot] avatar Jul 16 '22 21:07 codecov[bot]

This PR is suppose to allow huge wallet compounding operations to succeed (supporting hundreds of transactions). However I tested this on testnet with the help of @biospb, and it seems that some of the later transactions do not get processed by the network, possibly due to mempool cleanup policies (it takes the network a few minutes to process hundreds of huge transactions). It seems that only the first layer of compounding txs succeeds, while the following layers which depend on the first, are dropped eventually. Any thoughts @someone235 @svarogg before I close this ?

michaelsutton avatar Jul 17 '22 08:07 michaelsutton