adcomp icon indicating copy to clipboard operation
adcomp copied to clipboard

difference between make_install.R and devtools::install_github?

Open James-Thorson opened this issue 10 years ago • 3 comments

Hi all,

I confused myself recently by getting in the habit of installing github via the devtools function:

devtools::install_github("kaskr/adcomp/TMB", ref="v1.3.0")

where ref="v1.3.0" refers to a stable release. This advice is somewhat easier than advising to install github and clone adcomp, or download the ZIP file, and source the install file. It appears that this install_github() installation works fine for many uses of TMB (presumably given that Rtools is already installed), i.e., it can compile at least one TMB model I'm using.

However, the installation via devtools::install_github() doesn't correctly copy all files in the tmbutils directory, e.g., "R_inla.cpp". To get R_inla.cpp, I need to install by sourcing make_install.R, as per normal installation instructions.

So:

  1. Should I not ever use devtools::install_github() for installation?
  2. Can anyone explain for a novice package-builder why install_github() would copy some but not all of the files in tmbutils?

It is my experience that making installation feasible via install_github() would be somewhat easier for new users if convenient.

cheers, jim

James-Thorson avatar Apr 15 '15 13:04 James-Thorson

Hi Jim, What operating system are you using? Cheers, Mollie

mebrooks avatar Apr 15 '15 13:04 mebrooks

windows

James-Thorson avatar Apr 15 '15 13:04 James-Thorson

Did you ever figure out why R_inla.cpp was getting copied incorrectly? Is it still happening for you? I agree that devtools::install_github() is the simplest way to download code. Luckily we have the CRAN distribution now.

mebrooks avatar Feb 27 '16 10:02 mebrooks