netfox icon indicating copy to clipboard operation
netfox copied to clipboard

Published 20 hours ago • verified publisher icon kasketis

Realtime updates

Open alextud opened this issue 7 years ago • 12 comments

We have created a netfox_mac app which can connect to all apps (iOS or mac) that are running in local network using bonjour discovery mechanism.

Basically an iOS app that wants to expose it's network data to other mac app for inspection should activate bonjour service using: NFX.sharedInstance().startServer()

After that netfox_mac app can connect using the same UI as in the mac app with some teaks.

We want to merge back all changes into netfox repo after code and most of the new features are stable.

How that's sound, is it doable ? Thanks

screenshot 2018-02-09 16 51 12 screenshot 2018-02-09 16 51 30

alextud avatar Feb 09 '18 14:02 alextud

That's a very good idea guys! Thanks a lot! 🍻 @Janglinator do you have time to review it?

kasketis avatar Feb 12 '18 08:02 kasketis

Hi guys, thanks for your effort so far! I really appreciate it! 🤝👍 I reviewed the code and all seem good to me, but I face an issue while I'm trying to run the demo app. libraries seem to not include the Swifter lib you added through pods as I get a runtime error (dyld: Library not loaded: @rpath/Swifter.framework/Swifter). Did you face anything similar?

kasketis avatar Mar 05 '18 15:03 kasketis

I like this! I usually use Charles Proxy for this, but it can be a pain trying to get SSL working. This would avoid that issue altogether, and really help out our QA team

Janglinator avatar Mar 05 '18 20:03 Janglinator

@kasketis we dropped swifter dependency and cocoapods. Will double check by buillding it in a clean environment. Thanks

alextud avatar Mar 05 '18 20:03 alextud

This is looking really great guys! If you're daunted by the change requests, I can make them too. Just give me a thumbs up of when you're done testing, and I can start merging in and making the above changes.

Thanks so much for doing this! We certainly appreciate how much work has gone into it.

Janglinator avatar Mar 06 '18 05:03 Janglinator

@Janglinator There is an issue with continuous integration, can you look into that. On our side we need to update Readme page. Will move at the end description and images about netfox for mac integration.

alextud avatar Mar 13 '18 07:03 alextud

I added a pull request to @alextud's pull request repo (pull-request-ception!), so just waiting for him to get that pulled in, then CI should pass. The branch is already passing.

Janglinator avatar Mar 15 '18 03:03 Janglinator

@Janglinator I've move Readme notes about netfox_mac app in the second part of file. Also I've added a short thank you mention for tapptitude team. Thanks

alextud avatar Mar 15 '18 09:03 alextud

Hi, any news on this pull request being accepted ?

alextud avatar Jul 24 '18 08:07 alextud

Let's get this merged in! Would you be able to patch up the merge conflicts?

Janglinator avatar Sep 14 '18 19:09 Janglinator

@alextud The build failed, but that's because your commit doesn't support Swift 3.2.

I brought this up in PR #140, we might just drop Swift 3.2 support. So just wait for a response from @kasketis to see if you even need to make any changes.

Janglinator avatar Sep 17 '18 16:09 Janglinator

@Janglinator as we already need to start support to Swift 4.2, "soon" 5.0 I thing that would not be bad drop support for 3.2, even because to always maintain and try to follow best that swift can support, unfortunately today for swift environment we do need to migrate as soon as possible.

felipeflorencio avatar Sep 28 '18 07:09 felipeflorencio