Riley Park comments

Results 84 comments of


                                            Riley Park

Refactor buildscript to Kotlin DSL

I'd recommend looking into applying [indra](https://github.com/KyoriPowered/indra) first - see wiki for details.

Refactor buildscript to Kotlin DSL

@alexstaeding Are you able to update this pull request again? I pushed a few changes that break this a bit.

Default locale is not consistent throughout translations package

> > > if the system property is not set or is set to a specific locale, it defaults to `Locale.US` and is unchanging, even if the system property changes...

Publish test reports

https://docs.gradle.org/current/userguide/jacoco_plugin.html

Improve Javadocs for key API interfaces and methods

Is there anything that really needs improving currently, or is the javadocs at a good enough point to resolve this issue for now?

Make static methods that create objects distinct from those that create their builders.

I can agree with this - we can change `final TextComponent.Builder builder = Component.text()` into `final TextComponent.Builder builder = Component.textBuilder()`.

Make static methods that create objects distinct from those that create their builders.

So one thought I had today - introduce a new mechanism for constructing `Component`s: ```java interface Components { static TextComponent.@NonNull Factory text() { return new TextComponentImpl.FactoryImpl(); } } ``` ```java...

Make static methods that create objects distinct from those that create their builders.

There does not appear to be a way to make everyone happy, it seems - some people are against changing this (keeping both builder and non-builder methods named the same),...

Make static methods that create objects distinct from those that create their builders.

We will focus on improving documentation (#226, some work in #229) for right now - everyone seems to agree that lacking and/or short documentation is the main problem here.

Consider removal of convenience methods from Component

The reasoning for the convenience methods on `Component`: allow modifying without going to a full builder - for example: ```java Component component = this.someMethodThatReturnsComponent(); if(this.special()) { component = component.decorate(TextDecoration.BOLD); }...