copy-urls-expert icon indicating copy to clipboard operation
copy-urls-expert copied to clipboard

When instantSave = true (osx / unix-like), onunload event is fired incorrectly

Open sylee- opened this issue 8 years ago • 12 comments

This is probably user error, but I am unable to copy the title of the page and the URL.

I'm trying to give myself two major options:

  1. Copy the URLs of all tabs
  2. Copy the URLs of all tabs plus the title of the page.

I apologize if this is just me and not a bug.

sylee- avatar May 01 '16 02:05 sylee-

What is the version of firefox? Can you describe the steps you are doing and what do you expect?

kashiif avatar May 02 '16 06:05 kashiif

I just updated to Firefox 46, but I've been using your extension for a couple of months, at least.

This is what I get when I copy all the tabs in the window. And this is great because sometimes all I need to do is have a list so that I can open the links again later.

  • http://games.asobrain.com/
  • http://www.neurosciencemarketing.com/blog/
  • http://neurocritic.blogspot.com/
  • http://neurocritic.blogspot.com/2015/03/daylight-savings-time-and-dress.html
  • https://www.buzzfeed.com/catesish/help-am-i-going-insane-its-definitely-blue?utm_term=.dqarkJ6VX#.rdm4AyboV
  • https://www.brainpickings.org/
  • https://www.brainpickings.org/index.php/2012/02/27/purpose-work-love/
  • http://www.managingcommunities.com/2008/08/30/community-staff-members-must-be-experts-no/
  • http://www.managingcommunities.com/2008/12/25/staff-members-shouldnt-police-other-staff-members/
  • https://translate.google.com/
  • https://twitter.com/
  • https://twitter.com/alfredapp

Other times, it would be sooo very useful to have the title of the page along with the URLs. So, what I'd like to be able to get sometimes is something like:

  • AsoBrainGames - http://games.asobrain.com/
  • Neuromarketing - http://www.neurosciencemarketing.com/blog/
  • The Neurocritic - http://neurocritic.blogspot.com/
  • The Neurocritic: Daylight Savings Time and "The Dress" - http://neurocritic.blogspot.com/2015/03/daylight-savings-time-and-dress.html
  • Buzzfeed: What Colors Are This Dress? https://www.buzzfeed.com/catesish/help-am-i-going-insane-its-definitely-blue?utm_term=.dqarkJ6VX#.rdm4AyboV
  • Brain Pickings - https://www.brainpickings.org/
  • Brain Pickings: How to Find Your Purpose and Do What You Love - https://www.brainpickings.org/index.php/2012/02/27/purpose-work-love/
  • Managing Communities: Community Staff Members Must Be Experts? No! - http://www.managingcommunities.com/2008/08/30/community-staff-members-must-be-experts-no/
  • Community Staff Members/Moderators Shouldn’t Police Other Staff Members/Moderators - http://www.managingcommunities.com/2008/12/25/staff-members-shouldnt-police-other-staff-members/
  • Google Translate - https://translate.google.com/
  • Twitter - https://twitter.com/
  • Twitter: AlfredApps - https://twitter.com/alfredapp

At least, that's what I picture "$url$title$n" should look like.

But, I can't seem to get it to work. Once I managed to make a change to the customization of the format of the text for the clipboard, but I ended up with useless gobbledy-gook. The only way I could fix it was to uninstall and reinstall.

I hope that makes sense. Thank you for your time.

sylee- avatar May 02 '16 09:05 sylee-

@sylee- Fascinating links!

Gitoffthelawn avatar May 02 '16 10:05 Gitoffthelawn

The format string "$url$title$n" is correct and would get you the url followed by the title. However the example output could be achieved by format string "$title - $url$n"

To eliminate the possibility that this issue is not caused by any other extension, can you please try one of the following:

  1. Disable all extensions except CUE, restart firefox and try to get the urls list.
  2. Creat a new firefox profile. Start firefox with the new profile. Install CUE. (When you restart firefox after CUE installation, make sure you are using new profile. It should have only CUE in extensions). Now, try to get the urls list. (You can delete the new profile later when you are done. It won't affect your actual profile in any way)

If it gives you the output that you expected then you have got an extension that is not playing nice with CUE.

kashiif avatar May 02 '16 20:05 kashiif

Thank you. I'll try that. I hope it's one one of the other extensions. I don't have a lot, but finding "the one" - it'd probably be easier to find "Prince Charming".

sylee- avatar May 02 '16 21:05 sylee-

Here is what I have now, based on what you told me. All of my other extensions are off.

cue format

All I get are the URLs. If I can't get the name/title, don't worry. I'm ecstatic with this extension. Sometimes I'm copying and pasting more than 30 at a time and you've saved me so much time.

PS - Dollars to donuts, I should probably have showed you this first because of my troubles being my own fault.

PPS - I am thankful for your help here.

sylee- avatar May 02 '16 21:05 sylee-

Its probably because of the fact that you are not on windows :).

I tried it on my MAC. it seems to work but I found another issue.

Did you actually click on the save button (located at bottom right corner) before closing the preferences window?

Also if you make any change and click save, close the preferences dialog before making any other changes. So you change something, hit save, then change something and hit save; this is broken. Every time save is clicked, the dialog must be closed.

Note to Self: On MAC, it looks like 'unload' event was fired when save was clicked that sets the tree property to null. Subsequent calls to onDialogAccept() fail with the error message tree.cueTemplates is null.

kashiif avatar May 02 '16 23:05 kashiif

Awesome! Thank you so much. I'm glad that I was able to help you a little bit, too.

sylee- avatar May 02 '16 23:05 sylee-

So did it solve your problem?

kashiif avatar May 02 '16 23:05 kashiif

YES! YAY!!

One more question. Is there a way to choose which option I want to paste "on the fly" or do I need to go in and reset the default?

Either way, I'm delirious. Thank you so very much.

sylee- avatar May 03 '16 00:05 sylee-

That's covered in issue #14, but honestly, knowing that all that XUL based API will be thrown away from Firefox in the near future, I find little motivation to work on it.

Please leave this issue open so I can fix it for the root cause.

kashiif avatar May 03 '16 00:05 kashiif

@sylee- The original issue you were facing is fixed in release 2.6.1 available from AMO. Now, when you click the save button of options dialog, the dialog will close.

kashiif avatar Jan 15 '17 21:01 kashiif