Karl
Karl
Currently, this standard does not allow file URLs to have the hostname "localhost", instead replacing it with an empty hostname. Unfortunately, while both an empty hostname and "localhost" refer to...
I've been trying to port Chromium's file path file URL utilities to a project conforming to the latest standard. As far as I have been able to tell (it's a...
Typically, the URL parser detects Windows drive letters in the parsed path's "effective first component" (term I just made up). The path parser processes each component in turn, and pushing...
Hi! I'm trying to implement the current version of the spec in Swift (for non-browser applications. The idea is that it's useful to have a URL type that behaves as...
See [here](https://karwa.github.io/swift-url/0.3.1/documentation/weburl/foundationinterop/#URL-Strings-are-Ambiguous) for more information. In short: URL strings are ambiguous. IMO, APIs which accept a URL as a string should be deprecated, and replaced with APIs accepting a parsed...
Also remove an unneeded NIOFoundationCompat target dependency (it's only used by tests, not the AHC library itself). NIOTS also has an unconditional target dependency on NIOFoundationCompat. In the WebURL port,...
There are a couple of issues with `testConnectionPoolGrowsToMaxConcurrentConnections`: - The `maxConnections` variable [isn't passed down](https://github.com/swift-server/async-http-client/blob/99bd384b38578570382eba4729cceb158d134b6b/Tests/AsyncHTTPClientTests/HTTPConnectionPoolTests.swift#L143) to the `ConnectionPool` constructor. The expected value 8 happens to match the default, but shouldn't...
I noticed that I was able to replace the same-origin check in HTTPHandler with `if true` and `if false` and still pass all of the tests. https://github.com/swift-server/async-http-client/blob/f3521033efcf02027367197986afbbf6808a1ed8/Sources/AsyncHTTPClient/HTTPHandler.swift#L1241
AHC has an interesting quirk with how it supports `unix:` URLs - if the URL has a `baseURL`, the path of that base URL is taken as the socket path,...
As I mentioned in #109, a benchmark suite is important for ensuring a stable level of performance. Personally, I've been using https://github.com/google/swift-benchmark - it's a little rough around the edges,...