direct_mail icon indicating copy to clipboard operation
direct_mail copied to clipboard

inconsistent requirement for extension jumpurl

Open hloens opened this issue 2 years ago • 2 comments

In the file 'ext_emconf.php' the extension 'jumpurl' (friendsoftypo3/jumpurl) is required. In the 'require' section of the 'composer.json' it isn't mentioned. Shouldn't be the same for both installation versions, required or not?

hloens avatar Mar 31 '23 13:03 hloens

Totally agreed, since it was removed as a requirement in composer.json some time ago, I stumbled over the issue just on the upgrade, where the jumpurls were not working anymore. On the other hand the mighty optional dashboard is required (https://github.com/kartolo/direct_mail/issues/446).

It should at least be documented (here: https://docs.typo3.org/p/directmailteam/direct-mail/9.5/en-us/Configuration/EnablingClickStatistics/Index.html#) that this is required for the jumpurl functionality to work, as this is not apparent at first glance. Or have it as a hard requirement, since having it installed does not harm and makes that feature "work".

baschny avatar Dec 06 '23 16:12 baschny

BTW, it was removed here: https://github.com/kartolo/direct_mail/commit/3c2187407bb8365ca61ba324e112e174969260b6

which was part of the big v11 update: https://github.com/kartolo/direct_mail/pull/288

baschny avatar Dec 06 '23 16:12 baschny