direct_mail icon indicating copy to clipboard operation
direct_mail copied to clipboard

Published 20 hours ago • verified publisher icon kartolo

SQL error in DataHandler ignored

Open ccpp opened this issue 5 years ago • 2 comments

If DirectMailUtility::createDirectMailRecordFromPage does not succeed (in my case because of MySQL strict mode), this failure is ignored. (There is just a comment "TODO: Error message - Error while adding the DB set") - Here an error should be shown, or an exception should be thrown

ccpp avatar May 07 '19 21:05 ccpp

Do you mean this line? https://github.com/kartolo/direct_mail/blob/6782b17e6f60f499c245f651fdbdfaffb38de4a5/Classes/Module/Dmail.php#L673

kartolo avatar May 09 '19 07:05 kartolo

@kartolo Exactly! Sorry for my techy bug report, I should have added "ways to reproduce" at least: This happens when you try to create a newsletter from an internal page; Step 2 is shown even if there was an error creating the data set.

ccpp avatar May 09 '19 08:05 ccpp