hyper-express icon indicating copy to clipboard operation
hyper-express copied to clipboard

Vite middleware's 'originalUrl' and 'Request' object.

Open benoitlahoz opened this issue 1 year ago • 2 comments

Hello and thank you for this work!

As quoted in this issue vite development server writes to the originalUrl property of Request which doesn't work with HyperExpress.

I guess at least at these lines in vite:

The error is TypeError: Cannot set property originalUrl of #<Request> which has only a getter.

@DadiBit, the author of the issue, suggests that it is possible to extend Request to add the possibility for vite to change the property.

As I'm writing an adapter that would allow users to switch between Express and HyperExpress, my question is: how would one extend this class and 'inject' it in the HyperExpress process?

Any tip would be greatly appreciated. Thank you.

benoitlahoz avatar Nov 28 '24 13:11 benoitlahoz

Seems like we would need a setter here which can act as a setter on the internal url cache property.

Do you think you could make a PR which would add support for this?

kartikk221 avatar Dec 06 '24 02:12 kartikk221

Thank you for your answer. You can find an example for this PR here.

benoitlahoz avatar Dec 06 '24 11:12 benoitlahoz