popper icon indicating copy to clipboard operation
popper copied to clipboard

Small fixes for popper-tab-line-mode

Open Jake-Moss opened this issue 1 year ago • 2 comments

Thanks for this! These are the changes I alluded to on discord.

~~I found that when activating popper-tab-line-mode the rawkey was being used as a string, I looked at the old code and adapted that for a new strkey local var.~~

Also the popper-echo-dispatch-keys var was ordered with M-0 at the start, but then this key was being bound to index 0 with M-1 being 1 and so on. While this makes the digits align it meant the displayed tab number (1-based) didn't align with the keybinds when I added the current buffer to the tab-line like popper-echo-mode does. It also didn't align with my intuition that 1 was the current tab and then they moved left to right as shown, with 0 being 10.

I've also bound the var tab-line-close-tab-function to a lambda around kill-buffer so that they can be closed with the mouse. Previously the x did nothing.

The tab-line also doesn't appear when a popup is initially created. Although this also doesn't happen for popper-echo-mode.

Jake-Moss avatar Mar 24 '24 05:03 Jake-Moss

Thanks.

When I try using the dispatch keys I get

Error during redisplay: (eval (tab-line-format)) signaled (wrong-type-argument stringp nil) [14 times]

karthink avatar Mar 24 '24 17:03 karthink

Hmm, looking at my messages buffer I get that as well. Not sure where it's coming from, perhaps the cons of the open buffer to the buried buffers. If you're interested in these changes I'm happy to debug this but it seems like the tab-line is incredibly fragile from the discord messages.

Jake-Moss avatar Mar 24 '24 23:03 Jake-Moss

I'm no longer using tab-line-mode and given the other issues with it I don't feel I'll debugging this anytime soon. Thanks for your work on this and entertaining this though.

Jake-Moss avatar Apr 01 '24 01:04 Jake-Moss