karthink
karthink
@tschwinge Thanks for the PR. I've exhausted my available time for gptel fixing some bugs in the last release, so it'll be a few days before I can look at...
I haven't looked at `gptel-bedrock.el` yet, added a couple of remarks about the changes to the rest of gptel in my comments. It looks like you're only modifying Curl processes....
@felipeochoa Here's where we are on merging this: 1. `gptel--tool-args-to-json-schema`: Extracting this out to a separate function is either a mistake, or I'm missing something. You'll have to explain it...
@felipeochoa gentle ping about the last few remaining issues to merge this.
@akssri a new PR should be fine. Please retain @felipeochoa's authorship on their commits. We can squash the branch into a few commits (> 1) before merging.
Closed by #867 (which has been merged, even though GitHub says the PR is closed).
There isn't. PRs welcome.
> If you attempt to set the gptel-model to one that isn't hosted by the default gptel-backend, then it doesn't really do anything. Yeah, this is true. > The code...
> I'd probably want to avoid the use of strings since it's a bit of an emacs anti-pattern, symbols preferred. I'm not against using symbols for backend names, but why...
> Basically currently you cannot have different pricing of same models from different providers, which isn't ideal. > > Any ideas if this could be improved? Yes, this is because...