holepunch icon indicating copy to clipboard operation
holepunch copied to clipboard

Remote packages not recognized

Open bitbacchus opened this issue 4 years ago • 0 comments

First is first:

Thanks so much for the holepunch package! It's a awesome :-) :1st_place_medal:

I didn't actually experience this bug, but I read through the source code of write_compendium_description() and found, what I believe is a typo:

https://github.com/karthik/holepunch/blob/32479f8da69ea426fe9ca0ca64518b60456cf909/R/write_compendium_description.R#L47

As I understand it, this line is always false. It should be

if (length(remote_pkgs) > 0) { 

Best, Sebastian

bitbacchus avatar May 22 '20 11:05 bitbacchus