Karteek

> > Return nullptr (if you can confirm, it is ok in the above case if the args are not resolved). > > That should work. The method is already...

@kagamiori thanks for trying. I will rebase again and test it out.

@kagamiori Rebase is good. Are you sure you didn't miss any changes from this PR when you rebased on your end. The error that you saw happens if velox/core/SimpleFunctionMetadata.h file...

@kagamiori is it the same test failure?

> I am inlined the global constants. Hopefully this fixes the issue. Some references I found on this: https://stackoverflow.com/questions/50488831/use-of-constexpr-in-header-file

> ideas from DuckDb implementation Detail it out, what is the idea and how is it optimized with some example.

cc: @majetideepak

Just to clarify, computing the average in parts may deviate from averages as a whole. This happens because we are performing UnscaleLongDecimal division which rounds up fraction to the nearest...

Thanks for the suggestions @Yuhta.

I have applied iterative mean technique in this PR: https://github.com/facebookincubator/velox/pull/2763 One caveat is that Iteratively computing average would not behave as expected while requesting for Partial and Intermediate aggregations. What...