karrot-frontend icon indicating copy to clipboard operation
karrot-frontend copied to clipboard

Issue with accents and umlauts

Open dwaxweiler opened this issue 4 years ago • 44 comments

Step to reproduce

  1. Use Firefox on a Linux operating system (Ubuntu-based Pop! OS in my case).
  2. Type a letter with an accent or umlaut into one of the input fields, e.g. é or ö.

What happens The letter appears without its accent or umlaut.

What should happen The letter appears with its accent or umlaut.

I have observed this issue from version 9.6.0 on, but I have not gone back to the previous version to confirm it. It is the only website I use with this issue.

dwaxweiler avatar Feb 18 '22 10:02 dwaxweiler

weird. i tried (also with firefox and linux) but i dont have this problem on my side. try without extensions maybe?

amengsk avatar Feb 19 '22 15:02 amengsk

Hmm, yes sounds odd!

I manually deployed v9.0.0, can you check there? Much of the site probably won't work, as it will be out of step with the backend, but at least the login form is visible! --> https://v9.0.0.dev.karrot.world/#/login ... if that works we can keep doing it to narrow it down...

nicksellen avatar Feb 21 '22 10:02 nicksellen

@nicksellen Thanks for the deployment! There, accents and umlauts work for me. @brnsolikyl what about you for é?

dwaxweiler avatar Feb 21 '22 17:02 dwaxweiler

Yés, it wórks fine there! :) Every possible accent I could think of in Portuguese and Swedish worked.

brnsolikyl avatar Feb 21 '22 17:02 brnsolikyl

Ok, I deployed a couple more versions, can you check them @dwaxweiler

  • v9.0.0
  • v9.1.0 ?
  • v9.2.0 ?
  • v9.3.0
  • v9.4.0
  • v9.5.0-olddeps ✓ (v9.5.0 but dependencies from v9.4.0)
  • v9.5.0-patch ✓ (v9.5.0 but with manual change to quasar to attempt a revert of https://github.com/quasarframework/quasar/pull/9939/commits/cf0e5f199c56dbd55a055c1419bffd27b19e104e)
  • v9.5.0-patchmask ❌ (v9.5.0 but with https://patch-diff.githubusercontent.com/raw/quasarframework/quasar/pull/10022.patch applied in reverse...)
  • v9.5.0 ❌ <--- this one broke it! v9.4.0 -> v9.5.0 diff
  • v9.5.1 ?
  • v9.6.0 ❌

nicksellen avatar Feb 23 '22 10:02 nicksellen

@nicksellen, thanks! Version 9.3.0 works fine, version 9.5.0 does not.

dwaxweiler avatar Feb 23 '22 13:02 dwaxweiler

ok, getting there! so now try v9.4.0 ... then I can go to looking at changelogs...

nicksellen avatar Feb 23 '22 16:02 nicksellen

v.9.4.0 working here!

brnsolikyl avatar Feb 23 '22 19:02 brnsolikyl

@nicksellen, for me too!

dwaxweiler avatar Feb 24 '22 18:02 dwaxweiler

Hmm, interesting I'm not seeing much in the changes yet...

The most interesting dependency change is quasar from 1.15.21 to 1.15.23 (although not a big increase). The quasar release notes are here https://v1.quasar.dev/start/release-notes#introduction and one of the changes is about the QInput (text input):

fix(QInput): restore caret position in textarea #9915 (#9939)

... but that doesn't seem a very significant change.

Needs a bit more exploring...

nicksellen avatar Feb 24 '22 20:02 nicksellen

@dwaxweiler / @brnsolikyl can you try https://v9.5.0-olddeps.dev.karrot.world/#/login

(this is v9.5.0, but using the dependencies from v9.4.0)

nicksellen avatar Mar 01 '22 09:03 nicksellen

Works! :)

brnsolikyl avatar Mar 01 '22 09:03 brnsolikyl

Hmm, interesting. Can you try the input fields on https://v1.quasar.dev/vue-components/input

Any of these ones:

egfields

nicksellen avatar Mar 01 '22 09:03 nicksellen

Yep, not working there. So I guess you found the problem?

brnsolikyl avatar Mar 01 '22 09:03 brnsolikyl

Getting there... can you try https://quasar.dev/vue-components/input#example--design-overview (which is from the v2 version of quasar, we are still on v1 series...).

nicksellen avatar Mar 01 '22 09:03 nicksellen

Not working either

brnsolikyl avatar Mar 01 '22 10:03 brnsolikyl

Aha, a bug in quasar :)

It's this issue https://github.com/quasarframework/quasar/issues/10198, which was closed as they couldn't reproduce it either.

I'm going to try and isolate the specific change in quasar that introduced it to make a better case for making an issue over there.

nicksellen avatar Mar 01 '22 10:03 nicksellen

Can you try https://v9.5.0-patch.dev.karrot.world/#/login - I'm hoping that one works...

Edit: actually, I'm a bit confused right now, not sure what I'm expecting!

Edit2: ... actually, now I'm hoping that one doesn't work... I think there is another change in quasar that might have triggered the bug (https://github.com/quasarframework/quasar/pull/10022/files)

nicksellen avatar Mar 01 '22 10:03 nicksellen

This issue for firefox sounds like it's possibly talking about the same thing https://bugzilla.mozilla.org/show_bug.cgi?id=1077411 ... but some interaction with how quasar is doing things.

nicksellen avatar Mar 01 '22 10:03 nicksellen

Can you try https://v9.5.0-patch.dev.karrot.world/#/login - I'm hoping that one works...

That one works!

brnsolikyl avatar Mar 01 '22 10:03 brnsolikyl

How about https://v9.5.0-patchmask.dev.karrot.world/#/login ?

nicksellen avatar Mar 01 '22 11:03 nicksellen

How about https://v9.5.0-patchmask.dev.karrot.world/#/login ?

This one does not work for me, but the previous one does.

dwaxweiler avatar Mar 01 '22 11:03 dwaxweiler

How about https://v9.5.0-patchmask.dev.karrot.world/#/login ?

Does not work on Firefox, works on Chrome

brnsolikyl avatar Mar 01 '22 11:03 brnsolikyl

Ok, two more, then I think I'll write on the quasar issue:

  1. https://v9.5.0-quasar1.15.21.dev.karrot.world/#/login
  2. https://v9.5.0-quasar1.15.22.dev.karrot.world/#/login

These are both v9.5.0 (which doesn't work), but with slightly different quasar versions....

nicksellen avatar Mar 01 '22 13:03 nicksellen

None of the above works

brnsolikyl avatar Mar 01 '22 20:03 brnsolikyl

None of the above works

Oh :( that's disappointing, and slightly odd.

Ok, I made some codepens to just try out different quasar versions without all the complexity of Karrot:

  • https://codepen.io/nicksellen/pen/rNYomrJ (quasar v1.15.21) <-- corresponds to karrot v9.4.0
  • https://codepen.io/nicksellen/pen/XWzoRwY (quasar v1.15.22) <-- no karrot used this version
  • https://codepen.io/nicksellen/pen/xxPmdNQ (quasar v1.15.23) <-- corresponds to karrot v9.5.0

nicksellen avatar Mar 02 '22 20:03 nicksellen

Thanks for looking into this in depth, @nicksellen! Unfortunately, none of the codepens works for me.

dwaxweiler avatar Mar 02 '22 20:03 dwaxweiler

Oh, getting odder. Can you try again... I made a little error where the text value wasn't saved anywhere... also, does the normal text input field below the quasar one work?

nicksellen avatar Mar 02 '22 20:03 nicksellen

No difference! Yes, the normal input text field works in every codepen.

dwaxweiler avatar Mar 02 '22 21:03 dwaxweiler

@dwaxweiler @brnsolikyl Can you check if it works in Quasar v2? https://quasar.dev/vue-components/input

I tried it myself with typical German umlauts (äüö) in Firefox under Linux, but it all works fine. How do you actually enter the character? Do you have the character on your keyboard, do you use "dead keys" or do you use the "compose" key?

tiltec avatar Mar 14 '22 12:03 tiltec