neuraltalk icon indicating copy to clipboard operation
neuraltalk copied to clipboard

Maybe a mistake in lstm_generator.py

Open liu09114 opened this issue 10 years ago • 2 comments

In the lstm_generator.py, line 71 Hin[t,1:1+d] = X[t] and 72 Hin[t,1+d:] = prev should be exchanged. Because the hidden size is d, which is the dimension of the prev. But i don't why it doesn't raise an error, anyone can explain this?

liu09114 avatar Nov 19 '15 11:11 liu09114

I know why it doesn't raise an error. The default parameter of the image encoding size (also the input size) id equal to the hidden size. But the mistake should be correct.

liu09114 avatar Nov 19 '15 11:11 liu09114

oops, i think you're probably right. If you try to meddle with the sizes it would error.

karpathy avatar Nov 19 '15 17:11 karpathy