nanoGPT icon indicating copy to clipboard operation
nanoGPT copied to clipboard

Would like to contribute FSDP functionality

Open calmitchell617 opened this issue 1 year ago • 2 comments

Hi @karpathy,

I recently modified this repo to shard everything with PyTorch FSDP and would like to contribute this functionality to the project.

If I cleaned up the code and submitted a PR, is that something you would have a look at?

calmitchell617 avatar Mar 06 '24 14:03 calmitchell617

It's def on my todo list to incorporate FSDP into nanoGPT but I haven't looked into it in detail just yet. I also know that FSDP internals are being actively iterated on and might move around soon, so I'm waiting that out a little bit.

karpathy avatar Mar 06 '24 15:03 karpathy

Ok, should I bother putting together a PR?

calmitchell617 avatar Mar 06 '24 18:03 calmitchell617