nanoGPT icon indicating copy to clipboard operation
nanoGPT copied to clipboard

The issue of running on the Windows platform.

Open congyue1977 opened this issue 1 year ago • 1 comments

Fix the issue of runtime errors caused by PyTorch 2.0 not supporting compilation on the Windows platform.

congyue1977 avatar Apr 28 '23 10:04 congyue1977

Hi, just a random opinion from the internet :-)

I wouldn't do a code change for this because you can just set compile = False in your config file. The change made here doesn't follow the principle of least surprise. It is surprising that a default changes because of operating system, especially when the reason is not something innate to the operating system (e.g. path seperator), but something missing in Pytorch that might be added in the future.

mcapodici avatar Jul 16 '23 22:07 mcapodici