llama2.c icon indicating copy to clipboard operation
llama2.c copied to clipboard

fix allocation of scaling factors

Open moritztng opened this issue 6 months ago • 2 comments

allocate only one scaling factor per group

moritztng avatar Dec 09 '23 04:12 moritztng

huh. i'm only doing a quick skim atm. did i mess up the sizing of this oops

karpathy avatar Feb 13 '24 01:02 karpathy

you allocate dim elements for the quants and also dim elements for the scaling factors. but there are only dim / gs scaling factors :)

moritztng avatar Feb 13 '24 01:02 moritztng