Andrej
ok with the last commit I feel a bit better about things. `mingpt/fake_lightning.py` is now basically a minLightning :D, which could ideally be imported instead of Lightning and get a...
@williamFalcon ok done. few things I find a bit gross: - feels like I have to manually create a spurious `train_dataset`, because I need to know the size of vocab...
Alright calling it here for today, I'm tired and still have some actual work to do. I'm pretty sure I don't understand how `pl.LightningDataModule` API is supposed to be used...
Okay I merged one more big refactor. Honestly I am starting to think this branch was a very bad idea. I thought I could make things clean but there is...
Ok I think things have improved quite a bit. In particular, my "fake lightning" has now been reduced all the way to ```python class LightningModule(nn.Module): pass class Callback: pass ```...
minGPT isn't a library you install just yet, so mingpt has to be in your pythonpath. e.g. is your notebook opened in the root repo directory?
By the way, I am still making my way through the docs/code but I actually like what Lightning is trying to do, and I think will try to incrementally restructure...
cool, looking forward to 1.0!
My default is to dislike monolithic (Keras-like) frameworks and I also dislike forced coding styles that expand out code into billion lines of code and whitespace. I don't find it...
Thank you, half precision training was def on my list of todos, will take a look when I get a chance!