debug-attach-manager icon indicating copy to clipboard operation
debug-attach-manager copied to clipboard

With the use of the dark color scheme, the tick boxes do not display correctly

Open jpspringall opened this issue 8 years ago • 3 comments

This refers to https://marketplace.visualstudio.com/items?itemName=ViktarKarpach.DebugAttachManager- 9749#qna

As well as this when you mouse over you cannot see the text

When you mouse over an item, the highlight hides the tick and text doesnt look selected

But if you mouse the tick, you can see it's actually selected but mouse over tick and is selected

If you are busy let me know and I can have a go at fixing it.

Cheers

James

jpspringall avatar Aug 10 '17 21:08 jpspringall

Sure, if you have time go ahead and fix it. I am currently in a middle of implementation remote debug feature and this issue was next on my list after that feature.

Just make sure that you are using some kind of Visual Studio constant for hover text color, so it works for different themes (e.g. white theme).

karpach avatar Aug 11 '17 16:08 karpach

I actually just tried to reproduce that bug and was unable to. What version of VS are you using? Do you use the built-in dark theme?

karpach avatar Aug 14 '17 02:08 karpach

Hi Karpach,

Sorry had a busy day and not had a chance to update the thread.

I did some investigation over the weekend, and problem actually lies with the windows theme I was using (Windows Basic)

According to this post: https://stackoverflow.com/questions/2138200/change-background-color-for-selected-listbox-item

If we don't explicitly set the item colors for things like item mouse over, selected etc (Which it doesn't look like we do) It will pick it from system colors (ie Windows Theme)

So I think the fix is to update the ListBox.ItemContainerStyle to have the colors set, so that it uses these rather than Windows Theme Colors

I was going to look into this, but I've not done XAML before, so I was investigating how to do it.

jpspringall avatar Aug 14 '17 09:08 jpspringall