karmada-io
docs: add pprof analysis examples to Profiling Karmada
Add quick how-to commands for go tool pprof (top, interactive).
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Makes the usage examples for go tool pprof clearer and easier to follow.
Special notes for your reviewer: This is a small documentation change and my first contribution in this repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rainbowmango for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @Mou887! It looks like this is your first PR to karmada-io/website 🎉
Hello @XiShanYongYe-Chang , Thank you so much for you feedback ,
I checked Profiling Golang Programs on Kubernetes and Official Go Blog , They include pprof interactive mode commands like top10 and top5 -cum once inside the pprof prompt, but they donot include direct non-interactive CLI commands such as:
go tool pprof -top heap.pprof
go tool pprof -top cpu.pprof
These let developers get the same results in a single step without entering interactive mode. So I thought it's a good idea to add them.
Regarding the link Official Go Blog The https://blog.golang.org/pprof redirects to https://go.dev/blog/pprof which is not ideal so I will fix it and send the PR again.
Regarding the link Official Go Blog The
https://blog.golang.org/pprofredirects tohttps://go.dev/blog/pprofwhich is not ideal so I will fix it and send the PR again.
1. [Profiling Golang Programs on Kubernetes](https://danlimerick.wordpress.com/2017/01/24/profiling-golang-programs-on-kubernetes/)
I mean this link is no longer working.
Hi @XiShanYongYe-Chang , Thanks for the clarification !
I just re-checked the [Profiling Golang Programs on Kubernetes](https://danlimerick.wordpress.com/2017/01/24/profiling-golang-programs-on-kubernetes/ link in both the GitHub-rendered docs and locally in VS Code, and it opens successfully. Could you please share how you accessed it when it appeared broken?
I just re-checked the
[Profiling Golang Programs on Kubernetes](https://danlimerick.wordpress.com/2017/01/24/profiling-golang-programs-on-kubernetes/link in both the GitHub-rendered docs and locally in VS Code, and it opens successfully. Could you please share how you accessed it when it appeared broken?
Sorry, ignore my question; it was an issue with my environment. I changed the environment, and it works fine now.
Thank you . One question should I change the other link because it is getting redirected or let it be, because it is working ?
Thank you . One question should I change the other link because it is getting redirected or let it be, because it is working ?
If it can jump correctly, I think no modification is needed.