website icon indicating copy to clipboard operation
website copied to clipboard

Logging convensions

Open RainbowMango opened this issue 1 year ago • 2 comments

What documentation would you like to be added: Proposing to add documents for logging conversion, like https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md#logging-conventions.

Why do you think this document is needed: Creating a document for logging conventions is essential for maintaining consistency, ensuring readability, and facilitating effective troubleshooting and monitoring in the system.

Where do you think the document should be placed: I think the document could be placed under https://github.com/karmada-io/website/tree/main/docs/contributor More precisely, the document should be placed in this code directory: https://github.com/karmada-io/website/tree/main/docs/contributor/logging-convension.md

RainbowMango avatar Nov 05 '24 02:11 RainbowMango

Hi @RainbowMango,

I would like to work on adding a logging-conventions document for Karmada. I believe this document will help maintain consistency in logging practices, enhance debugging and monitoring, and align with best practices.

I’ve referred to the [Kubernetes Logging Conventions](https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md#logging-conventions) as a baseline and drafted a basic outline covering logging levels, formatting guidelines, and examples.

Could you please guide me on:

  1. Any specific logging practices or patterns that are unique to Karmada and should be included.
  2. How we can ensure this document is integrated effectively into the contributor guide.
  3. Any additional sections or details you think would be valuable for this document.

Looking forward to your guidance and feedback.

MAVRICK-1 avatar Dec 09 '24 21:12 MAVRICK-1

Hi @MAVRICK-1 Thank you in advance.

Currently, the Karmada project doesn't have a logging convention. That's why I proposing a document for this. The main difference between Karmada and Kubernetes is Karmada has not yet fully adopted structured logging.

RainbowMango avatar Dec 11 '24 02:12 RainbowMango