website icon indicating copy to clipboard operation
website copied to clipboard

add karmadactl init --config & karmadactl config documents

Open tiansuo114 opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind feature What this PR does / why we need it: The purpose of this pr is to make changes to and supplement the content of the document with the modifications in the issue Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

tiansuo114 avatar Sep 21 '24 14:09 tiansuo114

Welcome @tiansuo114! It looks like this is your first PR to karmada-io/website 🎉

karmada-bot avatar Sep 21 '24 14:09 karmada-bot

/hold pending for https://github.com/karmada-io/karmada/pull/5277

liangyuanpeng avatar Sep 23 '24 09:09 liangyuanpeng

@liangyuanpeng Mentor, where do you think it would be a better choice to place the supplementary configuration file documentation? I observed that in the Reference sidebar, there are two options: Command line tool (karmadactl) and karmada API. Currently, I have placed the documentation for this configuration file under Command line tool (karmadactl). Do you think this is the better choice, or would it be better placed elsewhere?

tiansuo114 avatar Oct 24 '24 02:10 tiansuo114

I recommend to add to https://karmada.io/docs/installation, WDYT? @XiShanYongYe-Chang

liangyuanpeng avatar Oct 24 '24 09:10 liangyuanpeng

/hold cancel

The karmada-io/karmada#5277 has been merged and the pr should now be able to continue the review and merge process

tiansuo114 avatar Oct 26 '24 04:10 tiansuo114

Hi Seems the comments mentioned above (https://github.com/karmada-io/website/pull/690#discussion_r1818434676) haven't been addressed.

RainbowMango avatar Oct 28 '24 11:10 RainbowMango

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Oct 29 '24 01:10 karmada-bot