website icon indicating copy to clipboard operation
website copied to clipboard

Karmada tutorial description needs correction.

Open zhzhuang-zju opened this issue 1 year ago • 5 comments

What would you like to be added:

Why is this needed: This description will lead to the misunderstanding that nginx application related resource are all propagated to member2 . In fact, these resources are also propagated to member1. https://github.com/karmada-io/website/blob/6e6656b7bcf80f62532be64e841c9a833d2aacba/docs/tutorials/resource-migration.md#L234-L235

zhzhuang-zju avatar Oct 08 '23 12:10 zhzhuang-zju

@zhzhuang-zju @RainbowMango Can I assign this issue to myself so I can work on this

shivansh-bhatnagar18 avatar May 23 '24 13:05 shivansh-bhatnagar18

Sure, go ahead~ You can think about how to change it first, and then synchronize to its older version. Looking forward to your feedback

zhzhuang-zju avatar May 24 '24 01:05 zhzhuang-zju

@zhzhuang-zju I think that in the verification part of Applying Higher Priority PropagationPolicy, we can add verification commands for both member1 and member2 clusters to clarify that the nginx application-related resources are propagated to both member1 and member2. The updated documentation will look something like this. Screenshot from 2024-05-24 18-23-37 Looking forward to your insights on this

shivansh-bhatnagar18 avatar May 24 '24 12:05 shivansh-bhatnagar18

@zhzhuang-zju I think that in the verification part of Applying Higher Priority PropagationPolicy, we can add verification commands for both member1 and member2 clusters to clarify that the nginx application-related resources are propagated to both member1 and member2.

Good idea~ To echo the theme, how about change the description to:

You should see the `nginx` application related resources originally in `member1` are also propagated to `member2`, completing the migration of resources.

zhzhuang-zju avatar May 25 '24 02:05 zhzhuang-zju

@zhzhuang-zju This explains better. I think we are good to go.

shivansh-bhatnagar18 avatar May 25 '24 08:05 shivansh-bhatnagar18