karmada icon indicating copy to clipboard operation
karmada copied to clipboard

Add PBD and priority class support for Karmada operator

Open jabellard opened this issue 1 week ago • 4 comments

What type of PR is this?

/kind feature

What this PR does / why we need it: Please see this issue: https://github.com/karmada-io/karmada/issues/6973

Which issue(s) this PR fixes:

Fixes #6973

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-operator Helm chart: Added support for configuring priority class and pod disruption budget config for Karmada operator deployment

jabellard avatar Dec 13 '25 17:12 jabellard

Summary of Changes

Hello @jabellard, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness and operational stability of the Karmada operator by introducing configurable support for Kubernetes Priority Classes and Pod Disruption Budgets (PDBs) via its Helm chart. These additions allow administrators to ensure the operator's critical components are prioritized during scheduling and maintain desired availability levels even during cluster maintenance or scaling events.

Highlights

  • Priority Class Support: The Karmada operator deployment can now be configured with a priorityClassName, allowing its pods to be scheduled with higher priority on Kubernetes clusters.
  • Pod Disruption Budget (PDB) Support: A new Pod Disruption Budget resource can be enabled for the Karmada operator, enhancing its availability during voluntary disruptions by ensuring a minimum number of pods remain available.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 13 '25 17:12 gemini-code-assist[bot]

/cc @RainbowMango @seanlaii

jabellard avatar Dec 13 '25 17:12 jabellard

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.59%. Comparing base (9ba7dc0) to head (d80ef83). :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7015      +/-   ##
==========================================
- Coverage   46.60%   46.59%   -0.01%     
==========================================
  Files         699      699              
  Lines       48182    48182              
==========================================
- Hits        22453    22451       -2     
  Misses      24032    24032              
- Partials     1697     1699       +2     
Flag Coverage Δ
unittests 46.59% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 13 '25 18:12 codecov-commenter

/assign

seanlaii avatar Dec 15 '25 00:12 seanlaii

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: seanlaii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Dec 15 '25 01:12 karmada-bot

Thanks /assign

zhzhuang-zju avatar Dec 15 '25 01:12 zhzhuang-zju

@jabellard Thanks, I have no further comments. It would be perfect if you could squash your commits into one.

zhzhuang-zju avatar Dec 15 '25 08:12 zhzhuang-zju

@jabellard Thanks, I have no further comments. It would be perfect if you could squash your commits into one.

I rebased and squashed this; nothing has changed since the last review.

/lgtm

RainbowMango avatar Dec 17 '25 03:12 RainbowMango