karmada icon indicating copy to clipboard operation
karmada copied to clipboard

operator e2e: add pdb e2e test

Open zhzhuang-zju opened this issue 1 week ago • 6 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: operator e2e: add pdb e2e test

Which issue(s) this PR fixes:

Part of #6282

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


zhzhuang-zju avatar Dec 10 '25 06:12 zhzhuang-zju

Summary of Changes

Hello @zhzhuang-zju, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing coverage for the Karmada operator by adding new end-to-end tests focused on PodDisruptionBudget (PDB) configurations. The tests ensure that the operator correctly handles PDB settings for its components, validating both invalid configurations and the proper lifecycle management (creation, update, and deletion) of PDBs when specified in the Karmada instance's common settings. This work contributes to the overall robustness and reliability of PDB management within Karmada deployments.

Highlights

  • New E2E Test Suite: Introduced a new end-to-end test suite specifically for PodDisruptionBudget (PDB) configuration within the Karmada operator.
  • PDB Configuration Validation: Added validation tests to ensure that Karmada deployments fail with invalid PDB configurations, such as when both minAvailable and maxUnavailable are empty or both are set simultaneously (as they are mutually exclusive).
  • PDB Lifecycle Management: Implemented functionality tests to verify the correct creation, update, and deletion of PDBs for the KarmadaControllerManager component based on the PodDisruptionBudgetConfig specified in the Karmada instance's common settings.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Dec 10 '25 06:12 gemini-code-assist[bot]

cc @baiyutang @jabellard @RainbowMango

zhzhuang-zju avatar Dec 10 '25 07:12 zhzhuang-zju

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 46.62%. Comparing base (90b8be2) to head (c691fb9). :warning: Report is 6 commits behind head on master. :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7010      +/-   ##
==========================================
- Coverage   46.64%   46.62%   -0.03%     
==========================================
  Files         699      699              
  Lines       48163    48184      +21     
==========================================
- Hits        22468    22464       -4     
- Misses      24000    24025      +25     
  Partials     1695     1695              
Flag Coverage Δ
unittests 46.62% <ø> (-0.03%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Dec 10 '25 07:12 codecov-commenter

/assign

jabellard avatar Dec 13 '25 20:12 jabellard

Thanks.

/lgtm

/cc @RainbowMango for another look.

jabellard avatar Dec 13 '25 20:12 jabellard

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Dec 16 '25 03:12 karmada-bot