refactor: unify maxAvailableComponentsSets calculation
What type of PR is this? /kind cleanup
What this PR does / why we need it:
Ref to https://github.com/karmada-io/karmada/pull/6912#issuecomment-3531756545
Given the high similarity in both algorithm and objective between the noderesource plugin and the resource model when computing maxAvailableComponentsSets, we can unify their computation logic.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign garrybest for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Summary of Changes
Hello @zhzhuang-zju, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the maxComponentSets calculation within the system by centralizing the scheduling simulation logic. It introduces a new SchedulingSimulator component that implements the First Fit Decreasing (FFD) algorithm, which is now used by both the noderesource plugin and the resource model to estimate workload capacity. This change aims to improve code reusability, reduce duplication, and enhance the maintainability of the estimation process.
Highlights
- Unified
maxComponentSetsCalculation: The logic for calculatingmaxAvailableComponentSetshas been unified, addressing duplication between thenoderesourceplugin and the resource model, as noted in the PR description. - Introduced
SchedulingSimulator: A newSchedulingSimulatorcomponent has been added inpkg/estimator/scheduling_simulator_components.goto encapsulate the First Fit Decreasing (FFD) scheduling algorithm, promoting code reuse and maintainability. - Refactored
noderesourcePlugin: Thenoderesourceplugin inpkg/estimator/server/framework/plugins/noderesource/noderesource.gonow utilizes the newSchedulingSimulatorfor its component estimation, removing its previously duplicated scheduling logic. - Updated Resource Model Calculation: The
getMaximumSetsBasedOnResourceModelsfunction inpkg/estimator/client/general.gohas been updated to leverage theSchedulingSimulatorfor more consistent and reusable capacity estimation, and several related helper functions have been removed.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
:x: Patch coverage is 32.25806% with 63 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 46.51%. Comparing base (22d9c36) to head (7fc053e).
:warning: Report is 2 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| pkg/estimator/scheduling_simulator_components.go | 0.00% | 61 Missing :warning: |
| pkg/estimator/client/general.go | 93.54% | 2 Missing :warning: |
| :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality. |
Additional details and impacted files
@@ Coverage Diff @@
## master #6997 +/- ##
==========================================
- Coverage 46.63% 46.51% -0.12%
==========================================
Files 699 700 +1
Lines 48163 48115 -48
==========================================
- Hits 22460 22382 -78
- Misses 24005 24045 +40
+ Partials 1698 1688 -10
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 46.51% <32.25%> (-0.12%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
/assign Thank you so much!