Enhance cluster deletion logic and index registration

[Chen-speculation]

What type of PR is this? /kind bug

What this PR does / why we need it:

• Move index registration to setupControllers for early availability
• Add fallback mechanism in cluster deletion when index queries fail
• Improve system robustness and reliability

Which issue(s) this PR fixes: Fixes #6886

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[karmada-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign whitewindmills for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/OWNERS
• pkg/controllers/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[karmada-bot]

Welcome @Chen-speculation! It looks like this is your first PR to karmada-io/karmada 🎉

[gemini-code-assist[bot]]

Summary of Changes

Hello @Chen-speculation, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the stability of cluster deletion operations and the availability of crucial data indexes. By relocating index registration to an earlier stage, it ensures that necessary indexes are always ready for use. Furthermore, it introduces a resilient fallback for cluster deletion, allowing the process to complete successfully even if index queries encounter issues, thereby preventing potential deadlocks or failures during cluster lifecycle management.

Highlights

• Index Registration Relocation: Moved the registration of ResourceBinding and ClusterResourceBinding indexes from startClusterController to setupControllers to ensure they are available earlier in the controller lifecycle, preventing potential race conditions or unavailability issues.
• Robust Cluster Deletion: Implemented a fallback mechanism in the cluster deletion logic. If an indexed query for ResourceBinding or ClusterResourceBinding fails, the system now performs a full list and manually filters the results, ensuring cluster deletion can proceed even if indexes are temporarily unavailable or misconfigured.
• Improved System Reliability: These changes collectively enhance the robustness and reliability of the system, particularly in scenarios involving cluster deletion and the availability of critical indexes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

[codecov-commenter]

:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

:x: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 46.34%. Comparing base (456e208) to head (eb22eac).

Files with missing lines	Patch %	Lines
pkg/controllers/cluster/cluster_controller.go	0.00%	22 Missing :warning:
cmd/controller-manager/app/controllermanager.go	0.00%	4 Missing :warning:
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6897      +/-   ##
==========================================
- Coverage   46.34%   46.34%   -0.01%     
==========================================
  Files         697      697              
  Lines       47629    47643      +14     
==========================================
+ Hits        22074    22078       +4     
- Misses      23889    23900      +11     
+ Partials     1666     1665       -1     

Flag	Coverage Δ
unittests	46.34% <0.00%> (-0.01%)	:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[RainbowMango]

@zach593 Can you help take a look?

[zach593]

Retrying after the error would certainly resolve the symptom, but we still need to understand why the error happens in the first place before adding this fix. I’ll try to reproduce the issue described in https://github.com/karmada-io/karmada/issues/6886 when I have time.