karmada icon indicating copy to clipboard operation
karmada copied to clipboard

JSON logging for multiclusterservice controllers

Open Bhaumik10 opened this issue 6 months ago • 2 comments

What type of PR is this?

JSON logging support. More details are highlighted in https://github.com/karmada-io/karmada/issues/6230.

Which issue(s) this PR fixes: Fixes # Partof https://github.com/karmada-io/karmada/issues/6230

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Bhaumik10 avatar Jun 16 '25 13:06 Bhaumik10

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 21.48760% with 95 lines in your changes missing coverage. Please review.

Project coverage is 49.05%. Comparing base (c7d4705) to head (a187059). Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../controllers/multiclusterservice/mcs_controller.go 28.57% 35 Missing :warning:
...clusterservice/endpointslice_collect_controller.go 13.15% 33 Missing :warning:
...lusterservice/endpointslice_dispatch_controller.go 20.58% 27 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6463      +/-   ##
==========================================
+ Coverage   49.03%   49.05%   +0.02%     
==========================================
  Files         687      687              
  Lines       56031    56061      +30     
==========================================
+ Hits        27473    27503      +30     
- Misses      26776    26778       +2     
+ Partials     1782     1780       -2     
Flag Coverage Δ
unittests 49.05% <21.48%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov-commenter avatar Jun 16 '25 14:06 codecov-commenter

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

karmada-bot avatar Jun 17 '25 15:06 karmada-bot

@Bhaumik10 , thanks for this work. For now, we're going to refrain from using the controller runtime logging adaptor to keep the scope of the parent task more constrained. As such, we'll continue using the klog logging funcs directly in the controllers. Please take a look at this PR, which is already merged, and make changes accordingly for this one. Thanks!

jabellard avatar Jun 25 '25 00:06 jabellard

@Bhaumik10 , thanks for this work. For now, we're going to refrain from using the controller runtime logging adaptor to keep the scope of the parent task more constrained. As such, we'll continue using the klog logging funcs directly in the controllers. Please take a look at this PR, which is already merged, and make changes accordingly for this one. Thanks!

@Bhaumik10 , please take a look and address when you get a change.

jabellard avatar Jul 01 '25 11:07 jabellard

closing this as opening up https://github.com/karmada-io/karmada/pull/6546

Bhaumik10 avatar Jul 16 '25 20:07 Bhaumik10